Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: intro .gif shows pre-keyless command-line flow #2764

Closed
tstromberg opened this issue Mar 2, 2023 · 2 comments · Fixed by #2943
Closed

README: intro .gif shows pre-keyless command-line flow #2764

tstromberg opened this issue Mar 2, 2023 · 2 comments · Fixed by #2943
Labels
bug Something isn't working

Comments

@tstromberg
Copy link
Contributor

https://github.com/sigstore/cosign/blob/main/images/intro.gif (included in the README.md) was last updated two years ago, in Feb 2021. It should be refreshed to demonstrate the new default keyless command-line flow.
@tstromberg tstromberg added the bug Something isn't working label Mar 2, 2023
@enyinna1234
Copy link
Contributor

I'd like to work on this issue.

@haydentherapper
Copy link
Contributor

Can we just delete it? We did that in the docs repo already. Given you can’t copy commands from it, it doesn’t add much value

enyinna1234 added a commit to enyinna1234/cosign that referenced this issue Apr 29, 2023
@enyinna1234
Removes old demo gif
b4fca9c 
This removes the old demo gif in the Readme. Keeps it in line
with changes in the docs repo.

Closes sigstore#2764

Signed-off-by: Enyinna Ochulor <[email protected]>
@enyinna1234 enyinna1234 mentioned this issue Apr 29, 2023
Merged
hectorj2f pushed a commit that referenced this issue Apr 29, 2023
@enyinna1234
Removes old demo gif (#2943)
2c2c663 
This removes the old demo gif in the Readme. Keeps it in line
with changes in the docs repo.

Closes #2764

Signed-off-by: Enyinna Ochulor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes old demo gif enyinna1234/cosign
3 participants
@tstromberg @haydentherapper @enyinna1234