Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign-blob --bundle clobbers --output-{signature,certificate} #1821

Closed
znewman01 opened this issue May 2, 2022 · 1 comment · Fixed by #2016
Closed

sign-blob --bundle clobbers --output-{signature,certificate} #1821

znewman01 opened this issue May 2, 2022 · 1 comment · Fixed by #2016
Labels
bug Something isn't working

Comments

@znewman01
Copy link
Contributor

If I pass all three of --output-signature, --output-certificate, and --bundle, Cosign silently only respects --bundle.

$ cosign sign-blob /dev/null --output-signature /tmp/keyless.sig --output-certificate /tmp/keyless.crt --bundle /tmp/keyless.bundle
[...]
$ ls /tmp/keyless.*
/tmp/keyless.bundle

I expect either:

  1. I get all three: a signature, a bundle, a cert (preferred)
  2. An error from the option parser

Guilty line looks like:

// if bundle is specified, just do that and ignore the rest

It appears that cosign sign does not support --bundle, though I'm not sure why not. CC @priyawadhwa who added it in #1306

@priyawadhwa
Copy link
Contributor

priyawadhwa commented Jun 20, 2022

Hey @znewman01 sorry I missed your ping in this issue! Basically for OCI images the bundle will be stored on the image, so it can be saved locally with cosign save and cosign load and offline verification will still work. But, this doesn't really work for blobs, so we added in --bundle for blobs only. The goal was offline verification for blobs. There's some more explanation in this issue: #1193

I think this is a bug though! I don't think --bundle should be clobbering the other flags, they should all be able to work at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants