Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vagarwal to triage #516

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

vipulagarwal
Copy link
Contributor

Summary

Requesting membership with triage permissions as discussed with @bobcallaway. Thank you!

Release Note

Documentation

Signed-off-by: Vipul Agarwal <[email protected]>
@vipulagarwal vipulagarwal requested review from a team as code owners November 21, 2024 00:27
Copy link

github-actions bot commented Nov 21, 2024

🍹 preview on sigstore-github-sync/sigstore/github-prod

Pulumi report
  Previewing update (sigstore/github-prod)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-prod/previews/3d50f21b-a71f-4c7e-8867-ccc9341d312c

@ Previewing update.....
pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:github-prod::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-prod]
  + github:index/membership:Membership: (create) 🔒
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/membership:Membership::vagarwal]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_3_2::fc324c44-57b2-4a20-a304-fbcea50f90e7]
      downgradeOnDestroy: false
      role              : "member"
      username          : "vagarwal"
  + github:index/repositoryCollaborator:RepositoryCollaborator: (create)
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::helm-charts-vagarwal]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_3_2::fc324c44-57b2-4a20-a304-fbcea50f90e7]
      permission               : "triage"
      permissionDiffSuppression: false
      repository               : "helm-charts"
      username                 : "vagarwal"
@ Previewing update....
Resources:
  + 2 to create
  591 unchanged
  

This reverts commit b88edd9.

Signed-off-by: Vipul Agarwal <[email protected]>
@vipulagarwal
Copy link
Contributor Author

@haydentherapper @bobcallaway can we merge this please? thanks

@bobcallaway
Copy link
Member

@haydentherapper @bobcallaway can we merge this please? thanks

@sigstore/core-team please weigh in

Copy link

@SantiagoTorres SantiagoTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick review of @vipulagarwal 's contributions in the last ~12 months. LGTM

@lukehinds lukehinds merged commit 3eb1e17 into sigstore:main Nov 22, 2024
2 checks passed
@vipulagarwal vipulagarwal deleted the add_vagarwal_triage branch November 22, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants