added hdc2080 decoder #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenugrec
suggested changes
May 2, 2024
| ## | ||
| ## This file is part of the libsigrokdecode project. | ||
| ## | ||
| ## Copyright (C) 2022 Jean Gressmann <[email protected]> |
There was a problem hiding this comment.
where is this copyright line from ? (doesn't match the one in the other file)
| ## OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| ## SOFTWARE. | ||
| ## | ||
|
|
There was a problem hiding this comment.
add links to documentation / datasheets; a short description paragraph wouldn't hurt
| # fixed to 100000, and the 1 LSBs can be configured. | ||
| # Thus, valid slave addresses (100000x) range from 0x40 to 0x41 | ||
| if addr not in [0x40, 0x41]: | ||
| s = 'Warning: I²C slave 0x%02x not an HDC2080 sensor.' |
There was a problem hiding this comment.
does this get printed if there is unrelated traffic on the i2c bus ? e.g. talking to an eeprom at the same time should not cause this PD to spam warnings on every transaction
Thanks for the comments! I'll get to work on it :) RE linking to PRs with dump & test suite, could that be in the same PR as this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any comments to improve/should be changed, please review.