Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rgb_led_ws281x rgb_led_clockless, add lighting tag, and add options for it to decode a wider range of rgb strips #119

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lsellens
Copy link

@lsellens lsellens commented Jul 2, 2024

Revamp of a lot of the code

  • Added a new option to specify the LED type (WS281x or SK6812) to resolves timing issues specific to SK6812 LEDs. Code is now more modular and can add other LED types with different timing requirements.
  • Added option for is_rgbw so white can be applied to any RGB order(might be a problem if any strips have white as any byte other then the 4th).
  • Moved preprocess options to its own method
  • Fixed handling of the last bit before the reset by extending its annotation and properly managing the reset timing
  • Added Lighting tag to it and rgb_led_spi
  • Added new annotation labels for bit_duration, high_period, and low_period.
  • Split 4th byte(white component) into its own annotation with options to display Hex Decimal or Percent.
  • Added option to display first 3 bytes(RGB components) in decimal format
  • Moved several repetitive tasks to their own methods.
  • Improved the handling of RESET conditions within the decode method, ensuring accurate annotation and timing.
    The decoder was tested with both WS2812b and SK6812 LED strips to confirm the accuracy of timing adjustments and bit handling improvements.

add Lighting tag to it and rgb_led_spi
- added a new option to specify the LED type (WS281x or SK6812) to resolves timing issues specific to SK6812 LEDs
- added option for is_rgbw so white can be applied to any RGB order(might be a problem if any strips have white as any byte other then the 4th)
- moved preprocess options to its own method
- fixed handling of the last bit before the reset by extending its annotation and properly managing the reset timing

The decoder was tested with both WS2812b and SK6812 LED strips to confirm the accuracy of timing adjustments and bit handling improvements.
…riod.

Split 4th byte(white component) into its own annotation with options to display Hex Decimal or Percent.
Added option to display first 3 bytes(RGB components) in decimal format.
Moved several repetitive tasks to their own methods.
Improved the handling of RESET conditions within the decode method, ensuring accurate annotation and timing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant