Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a new protocol of china fast power charger spec. UFCS. #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

392625227
Copy link

a new protocol decoder of china fast power charger spec. UFCS. full files under https://github.com/392625227/UFCS-protocol-compare-with-USB-PD.

@kamocat
Copy link

kamocat commented May 1, 2023

Hi Edison Ren,
Thank you for your contribution. To help me review this, please:

  • provide an English translation of the UFCS specification
  • create a pull request to sigrok-dumps for the signal capture ufcs_pv.sr.

Also, I want to ask about the stacked decoder. You chose to stack on top of the UART decoder, but it's not really UART-based. From your README:

The physical layer of UFCS is the UART serial port. Almost all MCUs have their own UART serial port hardware, which makes product development very simple. However, USB-PD adopts BMC encoding, which simply means that 1 and 0 are represented by the width of the pulse, and the high level of the signal is only about 1V, which requires a hardware comparator, which increases the cost.

This sounds like each UART bytes each represents a single bit, as in HDQ. Would it make more sense to measure the bit-width directly, as the SDQ decoder does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants