[WIP] rigol-ds: add DHO800 & DHO900 #229
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
reviewed
Nov 5, 2023
Comment on lines
+252
to
+253
| # Rigol DHO800 and DHO900 series | ||
| ATTRS{idVendor}=="1ab1", ATTRS{idProduct}=="044c", ENV{ID_SIGROK}="1" |
There was a problem hiding this comment.
lsusb says my DHO804 has a product id of 044d
Bus 003 Device 002: ID 1ab1:044d Rigol Technologies DHO804
|
On DHO804, scan works but acquisition fails: $ sigrok-cli -d rigol-ds:conn=tcp-raw/10.0.0.116/5555 --scan
The following devices were found:
rigol-ds - Rigol DHO804 00.01.02.00.00 [S/N: DHO8A254403951] with 4 channels: CH1 CH2 CH3 CH4$ sigrok-cli -d rigol-ds:conn=tcp-raw/10.0.0.116/5555 --frames 1 -O analog
sr: session: Could not start rigol-ds device (null) acquisition.
sr: session: Cannot remove non-existing event source 0x7.
Failed to start session. |
|
Verbose log |
|
Thanks for the log! Yeah, if you look at the PR contents, I had to add a whole new "protocol version" (really that enum just serves to signify changes between rigol's SCPI syntax etc., and should probably be implemented on a per-series level instead). There were enough changes from 'v5' that I got kinda discouraged and focused on my college work instead. This is a great time to continue working on this, though! I'll try solving this. |
|
Yeah I've looked at the patches briefly and tried to trace what's going on but it seems to lead into generic SCPI functions so I wasn't able to quickly figure it out (first time seeing the sigrok codebase). If you don't have DHO8 at hand and want to try, I can set-up a VM a with the scope connected to it and give you access to it. I'll have it at home till new year maybe a bit longer but even after that I could arrange remote access via some SBC I think. |
|
Thanks for the offer, but I do have a DHO9 on hand, and they are basically identical except it also has the digital channels. All documentation for one series applies equally to the other (same PDFs), again with the exception that the 900 series has LA channels. So, aside from the aforementioned udev rules, I think I should have everything I need... I'll let you know if I need to personally do specific testing on an 800. |
|
Yeah I don't know why I didn't realize this as I was reading the unlocking thread just a day before and they mention that you can turn DHO8 to DHO9 by just flipping some bits in vendors configuration. Anyway thanks for working on this! |
|
Is this PR still being worked on ? I just got a DHO804 and was considering looking at what additional changes are necessary to get this to work. |
|
FYI I got basic acquisition to work with 3430e8e But it isn't very stable, depending on the frame size on pulseview it may hang. I suspect it wouldn't be very hard to debug it from there, considering the commands are documented (https://rigolshop.eu/downloadable/download/attachment/id/42436/). |
fredzo
pushed a commit
to fredzo/libsigrok
that referenced
this pull request
Jul 22, 2024
Based on the work of Diana Ellefson (OrionOth) : sigrokproject#229 and RemiNV : sigrokproject@3430e8e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Rigol's new DHO800 & DHO900 series. I don't have a DHO800 myself, I do have a DHO924S which is what I will be testing with. That said, the two series seem very similar from what I can tell so supporting one is likely much the same as supporting both.
Conflicts with #228 , this PR is intended to do both.