Jolinux patch 1 was fix bug #1188 #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uint8_t and TAB fixed
|
a mistake |
byteit101
pushed a commit
to byteit101/libsigrok
that referenced
this pull request
May 21, 2023
Rephrase the sr_scpi_get_block() routine to increase readability and
robustness. Address data type issues (signedness). Rename variables to
better reflect their purpose. Concentrate more comments before larger
instruction sequences. Mention instructions' purpose first before more
detailled discussion, to speedup reader's navigation in the complex
logic. Reword the discussion of definite and indefinite length blocks.
Add more diagnostics. Although the text diff is huge, the spirit of
the previous implementation is kept.
Rephrase loops when the motivation for their phrasing was uncertain:
Replace "if (cond) do { ... } while (cond)" with just "while (cond)".
Which reduces nesting and indentation. Use "while" instead of "do while"
when it's obvious that the body does initially execute. It's believed
that behaviour remains identical.
This commit also changes behaviour: Re-arm timeouts more often after
receive data was seen. Which helps slow transports, yet does not harm
fast transports which already accumulated the input data for the next
stage of processing. Check for zero length in more locations (accept
phrases like "sigrokproject#10" as well).
There is excessive diagnostics. Needs more adjustment (wording, levels).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix TAB and uint8_t