Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get for packed leaves #2

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Fix get for packed leaves #2

merged 1 commit into from
Dec 9, 2021

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Dec 9, 2021 •
edited
Loading

Add a missed condition to get that affects lookups when leaves are packed. Testing is also expanded slightly.

Thanks @pawanjay176 for finding the bug!

pawanjay176
pawanjay176 approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@michaelsproul michaelsproul merged commit 78611c3 into main Dec 9, 2021
@michaelsproul michaelsproul deleted the fix-packed-get branch December 9, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @pawanjay176