Shifts tests to use random ports #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
force-pushed
the
random-ports-test
branch
from
e7a1aee to
32874e9
Compare
AgeManning
force-pushed
the
random-ports-test
branch
from
32874e9 to
42418f5
Compare
|
Should address #942 |
paulhauner
approved these changes
Apr 16, 2020
paulhauner
added
ready-to-squerge
and removed
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests appear to overlap on ports and fail CI non-deterministically.
This shifts some of the tests to use random open ports. Although there is still a chance ports can clash (as some tests use sequential port numbers) the probability of clashes should be low enough that it doesn't warrant changing the tests to check for random ports for each node.
Should CI continue to fail, a more rigorous method should be employed.