Modularize tracing executor and metrics rename #6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
approved these changes
Oct 17, 2024
jxs
approved these changes
Oct 18, 2024
|
I think we remove them entirely |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at e31ac50 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to move common crates to be more friendly to export.
This PR adds a tracing feature to the task executor, which removes the slog dependencies and logging.
This also renames the
lighthouse_metricscrate to justmetrics(as it doesn't contain lighthouse-specific metric code).