Remove VC response signing and update api-token in Lighthouse Book #6288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
waiting-on-author
Co-authored-by: Michael Sproul <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
michaelsproul
approved these changes
Aug 22, 2024
|
@mergify queue |
michaelsproul
added
ready-for-merge
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3c1266e |
5 tasks
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
…igp#6288) * update api-token * Update book/src/api-vc-auth-header.md Co-authored-by: Michael Sproul <[email protected]> * Update book/src/api-vc-auth-header.md Co-authored-by: Michael Sproul <[email protected]> * Update book/src/api-vc-endpoints.md Co-authored-by: Michael Sproul <[email protected]> * Update book/src/api-vc-endpoints.md Co-authored-by: Michael Sproul <[email protected]> * Remove 33 characeter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VC signature header is removed in #5529 , hence the page https://lighthouse-book.sigmaprime.io/api-vc-sig-header.html in Lighthouse book is no longer relevant (thanks @michaelsproul for the ping).
Also update the
api-tokento the new form