-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade re-org log to INFO #6220
Merged
mergify
merged 2 commits into
sigp:release-v5.3.0
from
michaelsproul:downgrade-reorg-log
Aug 5, 2024
Merged
Downgrade re-org log to INFO #6220
mergify
merged 2 commits into
sigp:release-v5.3.0
from
michaelsproul:downgrade-reorg-log
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
The code is ready for review
UX-and-logs
v5.3.0
Q3 2024 release with database changes!
labels
Aug 5, 2024
chong-he
reviewed
Aug 5, 2024
Co-authored-by: chonghe <[email protected]>
michaelsproul
added a commit
that referenced
this pull request
Aug 5, 2024
Squashed commit of the following: commit b4b9c18 Author: Michael Sproul <[email protected]> Date: Mon Aug 5 12:25:19 2024 +1000 Update book Co-authored-by: chonghe <[email protected]> commit 5b09e44 Author: Michael Sproul <[email protected]> Date: Mon Aug 5 09:37:49 2024 +1000 Downgrade re-org log to INFO
Looks good! |
macladson
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
macladson
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Aug 5, 2024
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 612946b |
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
* Downgrade re-org log to INFO * Update book Co-authored-by: chonghe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-for-merge
This PR is ready to merge.
UX-and-logs
v5.3.0
Q3 2024 release with database changes!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Downgrade the
WARN Beacon chain re-org
log toINFO
level.Re-orgs are a normal part of node operation and completely unactionable by the node operator. Removing this warning is long overdue.