Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertoor tests to CI #6192

Open
wants to merge 19 commits into
base: unstable
Choose a base branch
from
Open

Add assertoor tests to CI #6192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
766dbd0
asertooooooor
eserilev Jul 24, 2024
d8a99fb
remove mev boost proposal test
eserilev Jul 31, 2024
3601385
remove failing test
eserilev Jul 31, 2024
b72f50c
disable validator lifecycle
eserilev Jul 31, 2024
9143094
disable additional test
eserilev Jul 31, 2024
33adc07
Merge branch 'unstable' of https://github.com/sigp/lighthouse into ad…
eserilev Oct 7, 2024
00338e0
assertoor test changes
eserilev Oct 7, 2024
fb024ed
Merge branch 'unstable' of https://github.com/sigp/lighthouse into ad…
eserilev Oct 16, 2024
d2575ab
update tests
eserilev Oct 16, 2024
5b827d8
Fix tests
eserilev Oct 16, 2024
123bd3a
remove test
eserilev Oct 18, 2024
2a8a535
remove tests
eserilev Oct 18, 2024
dc08b74
fix tests
eserilev Oct 18, 2024
eb8bbbd
add calldata test
eserilev Oct 18, 2024
0303069
upload logs
eserilev Oct 18, 2024
0ee24d3
remove sync test
eserilev Oct 18, 2024
1a35d8c
bring back sync test
eserilev Oct 19, 2024
469eef8
Merge branch 'unstable' of https://github.com/sigp/lighthouse into ad…
eserilev Oct 19, 2024
3df5306
assertoor revert
eserilev Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/local-testnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ jobs:

- name: Install dependencies
run: |
sudo add-apt-repository ppa:rmescandon/yq
echo "deb [trusted=yes] https://apt.fury.io/kurtosis-tech/ /" | sudo tee /etc/apt/sources.list.d/kurtosis.list
sudo apt update
sudo apt install -y kurtosis-cli yq
sudo snap install yq
sudo apt install -y kurtosis-cli
kurtosis analytics disable

- name: Download Docker image artifact
Expand Down Expand Up @@ -69,6 +69,14 @@ jobs:
run: ./stop_local_testnet.sh local-blinded
working-directory: scripts/local_testnet

- name: Start a local testnet and run assertoor tests
uses: ethpandaops/kurtosis-assertoor-github-action@v1
with:
ethereum_package_args: scripts/tests/assertoor_network_params.yaml
path: |
scripts/local_testnet/logs
retention-days: 3
Comment on lines +76 to +78
Copy link
Member

@jimmygchen jimmygchen Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these keys are invalid for this github action. (see warnings on the run)
The step below defines the artifact path and retention, I think this can be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already upload the local testnet logs, did you mean to upload the assertoor logs? They could be included in the enclave logs too but i haven't checked


- name: Upload logs artifact
uses: actions/upload-artifact@v4
with:
Expand All @@ -85,10 +93,10 @@ jobs:

- name: Install dependencies
run: |
sudo add-apt-repository ppa:rmescandon/yq
echo "deb [trusted=yes] https://apt.fury.io/kurtosis-tech/ /" | sudo tee /etc/apt/sources.list.d/kurtosis.list
sudo apt update
sudo apt install -y kurtosis-cli yq
sudo snap install yq
sudo apt install -y kurtosis-cli
kurtosis analytics disable

- name: Download Docker image artifact
Expand Down Expand Up @@ -121,10 +129,10 @@ jobs:

- name: Install dependencies
run: |
sudo add-apt-repository ppa:rmescandon/yq
echo "deb [trusted=yes] https://apt.fury.io/kurtosis-tech/ /" | sudo tee /etc/apt/sources.list.d/kurtosis.list
sudo apt update
sudo apt install -y kurtosis-cli yq
sudo snap install yq
sudo apt install -y kurtosis-cli
kurtosis analytics disable

- name: Download Docker image artifact
Expand Down
23 changes: 23 additions & 0 deletions scripts/tests/assertoor_network_params.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Full configuration reference [here](https://github.com/ethpandaops/ethereum-package?tab=readme-ov-file#configuration).
participants:
- el_type: geth
el_image: ethereum/client-go:latest
cl_type: lighthouse
cl_image: lighthouse:local
cl_extra_params:
- --target-peers=3
count: 4
network_params:
deneb_fork_epoch: 0
seconds_per_slot: 6
num_validator_keys_per_node: 20
global_log_level: debug
snooper_enabled: false
additional_services:
- assertoor
assertoor_params:
run_stability_check: true
run_block_proposal_check: true
run_blob_transaction_test: true
tests:
- https://raw.githubusercontent.com/ethpandaops/assertoor-test/master/assertoor-tests/big-calldata-tx-test.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the big-calldata-tx-test.yaml is the one taking the most time (>20m) and doesn't run concurrently with the other 3 tests. Maybe we can exclude this one from the CI job and have it as a recurring test on GitHub action?

Loading