Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile to work on latest version of Docker #6087

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Update Dockerfile to work on latest version of Docker #6087

merged 1 commit into from
Jul 15, 2024

Conversation

jimmygchen
Copy link
Member

Issue Addressed

After updating my Docker version to latest (27.0.3), I get the following error when trying to build a Lighthouse image. Looks like the legacy format is no longer supported. This PR updates the Dockerfile to use the ENV key=value format instead of ENV key value.

 => CANCELED [builder 4/4] RUN cd lighthouse && make                                                                           10.7s

 2 warnings found (use --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 7)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 8)
ERROR: failed to solve: Canceled: context canceled

@jimmygchen jimmygchen added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Jul 12, 2024
@jimmygchen jimmygchen changed the title Update Dockerfile to work on newer version of Docker. Update Dockerfile to work on latest version of Docker Jul 12, 2024
michaelsproul
michaelsproul approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed working on Docker 25 as well (the version on my Ubuntu machine)

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 15, 2024
@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jul 15, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at cb1e8dc

mergify bot added a commit that referenced this pull request Jul 15, 2024
@mergify
Merge of #6087
b9e0d35
@mergify mergify bot mentioned this pull request Jul 15, 2024
Closed
5 tasks
@mergify mergify bot merged commit cb1e8dc into sigp:unstable Jul 15, 2024
27 of 28 checks passed
ThreeHrSleep pushed a commit to ThreeHrSleep/lighthouse that referenced this pull request Aug 1, 2024
@jimmygchen @ThreeHrSleep
Update Dockerfile to work on latest version of Docker (sigp#6087)
c351a5c 
* Update Dockerfile to use the non legacy syntax `ENV key=value` instead of `ENV key value`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmygchen @michaelsproul