-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds with slasher-redb
#6077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Oops, there's one failing slasher test: |
Deleted the failing test. It's a duplicate of another test with the same name |
Ok third time lucky. Disabled all those slasher override tests when redb is involved. |
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 7697c12 |
Issue Addressed
Currently
unstable
fails to build with theslasher-redb
feature due to a last-minute tweak I made to theredb
impl prior to merging.Proposed Changes
redb
slasher on CI (would have caught this issue)