Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent connections from peers with a banned ip history #6008

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

AgeManning
Copy link
Member

This synchronizes the logic we have between what peers we allow to connect to us and what think are connecting to us.

Specifically, peers that have a history of connecting to us via an IP address that is currently banned (i.e has a number of peers currently banned associated with this IP) we prevent their connection, even if they are connecting on a new IP address.

This should resolve some potential error logs also.

@AgeManning AgeManning added ready-for-review The code is ready for review v5.2.1 Patch release for v5.2.0 labels Jun 27, 2024
@AgeManning AgeManning requested a review from jxs June 27, 2024 05:40
@AgeManning AgeManning added v5.3.0 Q3 2024 release with database changes! and removed v5.2.1 Patch release for v5.2.0 labels Jun 27, 2024
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple fix!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 27, 2024
@jimmygchen
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jun 27, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 9b093c8

mergify bot added a commit that referenced this pull request Jun 27, 2024
@mergify mergify bot merged commit 9b093c8 into sigp:unstable Jun 27, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v5.3.0 Q3 2024 release with database changes!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants