-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block_gossip
Beacon API events
#5864
Merged
mergify
merged 39 commits into
sigp:unstable
from
chong-he:BeaconAPI-events-block-gossip
Jul 16, 2024
Merged
Add block_gossip
Beacon API events
#5864
mergify
merged 39 commits into
sigp:unstable
from
chong-he:BeaconAPI-events-block-gossip
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Sproul <[email protected]>
chong-he
added
ready-for-review
The code is ready for review
and removed
work-in-progress
PR is a work-in-progress
labels
Jun 6, 2024
I'm going to drop this from 5.2.1 as it's not an essential part of the hotfix |
michaelsproul
added
v5.3.0
Q3 2024 release with database changes!
and removed
v5.2.1
Patch release for v5.2.0
labels
Jun 25, 2024
michaelsproul
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good, and I tested manually to ensure we were using quotes on the slot
(we are). Good to go for 5.3
michaelsproul
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Jul 16, 2024
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 79680c8 |
This was referenced Jul 16, 2024
Merged
ThreeHrSleep
pushed a commit
to ThreeHrSleep/lighthouse
that referenced
this pull request
Aug 1, 2024
* Add bls event * Update events and types * Add bls in event * Event bls * tests..rs * change order * another tests.rs * Signed BLS * Revert "another tests.rs" This reverts commit 7f54e9c. * Revert "Signed BLS" This reverts commit 1146bc7. * withdrawal_keyparis * Fix genesis * block gossip * Add definition for BlockGossip * Fix block gossip * Tests.rs * Update block and events * Add bls event * Event bls * tests..rs * change order * another tests.rs * Signed BLS * Revert "another tests.rs" This reverts commit 7f54e9c. * Revert "Signed BLS" This reverts commit 1146bc7. * block gossip * Add definition for BlockGossip * Fix block gossip * Tests.rs * Update block and events * Merge branch 'BeaconAPI-events-block-gossip' of https://github.com/chong-he/lighthouse into BeaconAPI-events-block-gossip * Remove tests * Tests.rs * Tests.rs * Tests.rs * Tests similar to block event * Update common/eth2/src/types.rs Co-authored-by: Michael Sproul <[email protected]> * Merge remote-tracking branch 'origin/unstable' into BeaconAPI-events-block-gossip * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
block_gossip
topic to the beacon APIeth1/v1/events
Thank you @michaelsproul for the guidance and help