Type sync network context send errors #5808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
approved these changes
May 17, 2024
jimmygchen
reviewed
May 17, 2024
| @@ -52,31 +52,43 @@ pub enum RpcEvent<T> { | |||
| RPCError(RPCError), | |||
| } | |||
|
|
|||
| pub type RpcProcessingResult<T> = Result<(T, Duration), LookupFailure>; | |||
| pub type RpcRequestResult<T> = Result<(T, Duration), RpcResponseError>; | |||
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 8006418 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
SyncNetworkContext has a bunch of functions that send messages to network channel and processor channel with signature
So far this is okay-ish, but in das we introduce more complex failure modes that can't be coerced to a static string. See:
lighthouse/beacon_node/network/src/sync/network_context.rs
Line 681 in 8059c3a
Proposed Changes
Type sync network context send errors in unstable, and backport to das when merged