Fix stuck backfill when scheduled work queue is at capacity #5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
force-pushed
the
fix-stuck-backfill
branch
3 times, most recently
from
2964f1c
to
20d0110
Compare
jimmygchen
force-pushed
the
fix-stuck-backfill
branch
from
20d0110
to
4f8c6ac
Compare
realbigsean
requested changes
Apr 16, 2024
|
|
||
| // Advance the time by more than 1/2 the slot to trigger a scheduled backfill batch to be sent. | ||
| // This should fail as the `ready_work` channel is at capacity, and it should be rescheduled. | ||
| let more_than_half_slot = Duration::from_secs(slot_duration / 2 + 1); |
There was a problem hiding this comment.
So this is to hit the timing defined by BACKFILL_SCHEDULE_IN_SLOT, right? Can we use that directly here so as to not break this test in the future if this schedule changes?
realbigsean
added
waiting-on-author
jimmygchen
added
ready-for-review
realbigsean
approved these changes
Apr 22, 2024
realbigsean
added
ready-for-merge
…x-stuck-backfill
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 532206e |
This was referenced Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses #5504.
Fix stuck backfill when scheduled work queue is at capacity and make sure the batch is rescheduled.
Additional Info
I tried adding a regression test but can't get it to pass. Will look into it next week.(fixed)