Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging in UnknownBlockHashFromAttestation handling #5546

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

dapplion
Copy link
Collaborator

Issue Addressed

Continues

Proposed Changes

by adding the same style of logging to UnknownBlockHashFromAttestation:

  • One log for each received event
  • If event is ignored, log once why, reusing should_search_for_block

Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@realbigsean
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Apr 10, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 54fbdda

@realbigsean realbigsean added the ready-for-merge This PR is ready to merge. label Apr 10, 2024
@mergify mergify bot merged commit 54fbdda into sigp:unstable Apr 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants