-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kzg interface #4077
Merged
Merged
Update kzg interface #4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jimmygchen Not able to request you as reviewer for some reason. |
realbigsean
approved these changes
Mar 13, 2023
jimmygchen
reviewed
Mar 14, 2023
after this Pr the main branch no longer checks. beacon_node/beacon_chain/src/beacon_chain.rs:4763:28: error[E0425]: cannot find function `compute_aggregate_kzg_proof` in module `kzg_utils`
beacon_node/beacon_chain/src/beacon_chain.rs:4777:24: error[E0425]: cannot find function `validate_blobs_sidecar` in module `kzg_utils`
beacon_node/beacon_chain/src/blob_verification.rs:138:20: error[E0425]: cannot find function `validate_blobs_sidecar` in module `kzg_utils` |
Thanks @pawanjay176 and @divagant-martian |
Sorry for borking the base branch 😅 Didn't realise we still had all the kzg computation from coupling days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #4076
Proposed Changes
Updates the kzg interface for freeing the blobs.