Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kzg interface #4077

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Conversation

pawanjay176
Copy link
Member

Issue Addressed

Resolves #4076

Proposed Changes

Updates the kzg interface for freeing the blobs.

@pawanjay176
Copy link
Member Author

@jimmygchen Not able to request you as reviewer for some reason.

@realbigsean realbigsean mentioned this pull request Mar 13, 2023
10 tasks
crypto/kzg/Cargo.toml Outdated Show resolved Hide resolved
@pawanjay176 pawanjay176 merged commit 76f49bd into sigp:deneb-free-blobs Mar 14, 2023
@divagant-martian
Copy link
Collaborator

divagant-martian commented Mar 14, 2023

after this Pr the main branch no longer checks.
Doing cargo clean and then cargo check produces

beacon_node/beacon_chain/src/beacon_chain.rs:4763:28: error[E0425]: cannot find function `compute_aggregate_kzg_proof` in module `kzg_utils`
beacon_node/beacon_chain/src/beacon_chain.rs:4777:24: error[E0425]: cannot find function `validate_blobs_sidecar` in module `kzg_utils`
beacon_node/beacon_chain/src/blob_verification.rs:138:20: error[E0425]: cannot find function `validate_blobs_sidecar` in module `kzg_utils`

@jimmygchen
Copy link
Member

Thanks @pawanjay176 and @divagant-martian
I'll update my branch with @pawanjay176 's changes and this should fix the compilation error.

@pawanjay176
Copy link
Member Author

Sorry for borking the base branch 😅 Didn't realise we still had all the kzg computation from coupling days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants