Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Don't use the builder network if the head is optimistic #3412

Conversation

realbigsean
Copy link
Member

Issue Addressed

Resolves #3394

Adds a check in is_healthy about whether the head is optimistic when choosing whether to use the builder network.

@realbigsean realbigsean added the bellatrix Required to support the Bellatrix Upgrade label Aug 2, 2022
@realbigsean realbigsean added the ready-for-review The code is ready for review label Aug 5, 2022
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 9, 2022
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 9, 2022
## Issue Addressed

Resolves #3394

Adds a check in `is_healthy` about whether the head is optimistic when choosing whether to use the builder network. 



Co-authored-by: realbigsean <[email protected]>
@bors
Copy link

bors bot commented Aug 9, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@michaelsproul
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Aug 9, 2022

Canceled.

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 9, 2022
## Issue Addressed

Resolves #3394

Adds a check in `is_healthy` about whether the head is optimistic when choosing whether to use the builder network. 



Co-authored-by: realbigsean <[email protected]>
@bors bors bot changed the title Don't use the builder network if the head is optimistic [Merged by Bors] - Don't use the builder network if the head is optimistic Aug 9, 2022
@bors bors bot closed this Aug 9, 2022
@realbigsean realbigsean deleted the dont-use-builder-with-optimistic-head branch November 21, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bellatrix Required to support the Bellatrix Upgrade ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants