-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Enable count-unrealized
by default
#3389
Closed
michaelsproul
wants to merge
1
commit into
sigp:unstable
from
michaelsproul:count-unrealized-default-cli
Closed
[Merged by Bors] - Enable count-unrealized
by default
#3389
michaelsproul
wants to merge
1
commit into
sigp:unstable
from
michaelsproul:count-unrealized-default-cli
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
The code is ready for review
bellatrix
Required to support the Bellatrix Upgrade
v2.5.0
Required for Goerli merge release
labels
Jul 29, 2022
paulhauner
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
paulhauner
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Jul 29, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
## Issue Addressed Enable #3322 by default on all networks. The feature can be opted out of using `--count-unrealized=false` (the CLI flag is updated to take a parameter).
This PR was included in a batch that timed out, it will be automatically retried |
bors r- |
Canceled. |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 30, 2022
## Issue Addressed Enable #3322 by default on all networks. The feature can be opted out of using `--count-unrealized=false` (the CLI flag is updated to take a parameter).
bors
bot
changed the title
Enable
[Merged by Bors] - Enable Jul 30, 2022
count-unrealized
by defaultcount-unrealized
by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bellatrix
Required to support the Bellatrix Upgrade
ready-for-merge
This PR is ready to merge.
v2.5.0
Required for Goerli merge release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Enable #3322 by default on all networks.
The feature can be opted out of using
--count-unrealized=false
(the CLI flag is updated to take a parameter).