Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Enable count-unrealized by default #3389

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Enable #3322 by default on all networks.

The feature can be opted out of using --count-unrealized=false (the CLI flag is updated to take a parameter).

@michaelsproul michaelsproul added ready-for-review The code is ready for review bellatrix Required to support the Bellatrix Upgrade v2.5.0 Required for Goerli merge release labels Jul 29, 2022
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 29, 2022
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 29, 2022
## Issue Addressed

Enable #3322 by default on all networks.

The feature can be opted out of using `--count-unrealized=false` (the CLI flag is updated to take a parameter).
@bors
Copy link

bors bot commented Jul 30, 2022

This PR was included in a batch that timed out, it will be automatically retried

@paulhauner
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Jul 30, 2022

Canceled.

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 30, 2022
## Issue Addressed

Enable #3322 by default on all networks.

The feature can be opted out of using `--count-unrealized=false` (the CLI flag is updated to take a parameter).
@bors bors bot changed the title Enable count-unrealized by default [Merged by Bors] - Enable count-unrealized by default Jul 30, 2022
@bors bors bot closed this Jul 30, 2022
@michaelsproul michaelsproul deleted the count-unrealized-default-cli branch July 30, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bellatrix Required to support the Bellatrix Upgrade ready-for-merge This PR is ready to merge. v2.5.0 Required for Goerli merge release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants