Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add merge transition docs #3361

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Add merge transition docs #3361

wants to merge 5 commits into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

Add some documentation about migrating pre-merge Lighthouse to post-merge Lighthouse.

Additional Info

NA

@paulhauner paulhauner added work-in-progress PR is a work-in-progress v2.5.0 Required for Goerli merge release labels Jul 22, 2022
@paulhauner paulhauner changed the base branch from stable to unstable July 22, 2022 06:52
@paulhauner paulhauner added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jul 25, 2022
@paulhauner
Copy link
Member Author

I've marked this as ready-for-review since I'm keen to make it available. I'm interested in typos and corrections where things are wrong, but I'd prefer to put any additions in a new PR in the spirit of something being better than nothing. Future PRs can always expand upon it.

@paulhauner paulhauner marked this pull request as ready for review July 25, 2022 08:29
pawanjay176
pawanjay176 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the tiny typo

book/src/merge-migration.md Outdated Show resolved Hide resolved
@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 26, 2022
@paulhauner
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 26, 2022
@paulhauner
Add merge transition docs (#3361)
b82e2df 
## Issue Addressed

NA

## Proposed Changes

Add some documentation about migrating pre-merge Lighthouse to post-merge Lighthouse.

## Additional Info

NA
@bors
Copy link

bors bot commented Jul 26, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Add merge transition docs [Merged by Bors] - Add merge transition docs Jul 26, 2022
@bors bors bot closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. v2.5.0 Required for Goerli merge release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulhauner @pawanjay176