Log about historical backfill less frequently #2600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
This proposal changes the way we log when we're doing a historical back fill. Presently, we log like this:
This PR changes it so the logs look more like this:
In this new logging format we log the typical
Synced
logs and then every 5 slots (1 minute) we log about the historical back fill progress (if back fill is in progress).I think logging the typical
Synced
messages with the occasional back fill message will place the "your node is synced and ready" message in the foreground and the "backfill is in progress" message in the background. I worry the existing logs might place the historical sync at the foreground, without making it clear that we're ready to go for staking.Also, the typical
Synced
messages print info about the current slot, epoch and finalized epoch which I think is handy to see.Additional Info
I've added a little
Historical block download complete
message when the notifier sees that we were back filling, but aren't anymore. I haven't actually seen this log fire because my node hasn't finished back filling yet. I'll keep an eye on it.