Network Update for Weak Subjectivity Sync #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
force-pushed
the
network-wss
branch
2 times, most recently
from
f89b69b to
626b0e8
Compare
michaelsproul
force-pushed
the
network-wss
branch
from
cd8c1e7 to
ce13ae8
Compare
7 tasks
beacon_node/network/src/beacon_processor/worker/sync_methods.rs
Outdated
Show resolved
Hide resolved
| ); | ||
| "invalid_signature".into() | ||
| } | ||
| HistoricalBlockError::ValidatorPubkeyCacheTimeout => { |
There was a problem hiding this comment.
I had to add this error type when adding signature verification. Unlike the other errors this is our fault rather than the peer's, so we probably shouldn't penalise them, although I realise that might be hard to tweak.
There was a problem hiding this comment.
Yeah. This is a bit more work.
I think maybe we leave this, unless we expect this to occur regularly. Maybe we see how it goes in the wild and if its necessary, I can add in extra conditions where we don't penalize the peer.
There was a problem hiding this comment.
I've set the timeout super long so it really shouldn't happen unless the hardware is getting completely slogged. Should be fine to leave as-is.
AgeManning
added
ready-for-review
michaelsproul
approved these changes
Sep 14, 2021
bors bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
## Issue Addressed Closes #1891 Closes #1784 ## Proposed Changes Implement checkpoint sync for Lighthouse, enabling it to start from a weak subjectivity checkpoint. ## Additional Info - [x] Return unavailable status for out-of-range blocks requested by peers (#2561) - [x] Implement sync daemon for fetching historical blocks (#2561) - [x] Verify chain hashes (either in `historical_blocks.rs` or the calling module) - [x] Consistency check for initial block + state - [x] Fetch the initial state and block from a beacon node HTTP endpoint - [x] Don't crash fetching beacon states by slot from the API - [x] Background service for state reconstruction, triggered by CLI flag or API call. Considered out of scope for this PR: - Drop the requirement to provide the `--checkpoint-block` (this would require some pretty heavy refactoring of block verification) Co-authored-by: Diva M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the network part to the weak subjectivity sync.