Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add contribution and proof event #2527

Closed

Conversation

realbigsean
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Add the new ContributionAndProof event: ethereum/beacon-APIs#158

Additional Info

N/A

@realbigsean realbigsean added ready-for-review The code is ready for review work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Aug 19, 2021
@realbigsean realbigsean added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Aug 20, 2021
@realbigsean realbigsean added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Aug 24, 2021
@realbigsean
Copy link
Member Author

Seems like there's an error with this on windows

@realbigsean realbigsean added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Sep 3, 2021
@realbigsean
Copy link
Member Author

This was annoying to figure out but it was an issue of the events channel capacity being too low in our tests (1, I upped it to 5). For some reason this only caused issues on windows.

Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, sorry about the review delay! I can't fault it!

bors r+

@paulhauner paulhauner removed the ready-for-review The code is ready for review label Sep 25, 2021
@paulhauner paulhauner added the ready-for-merge This PR is ready to merge. label Sep 25, 2021
bors bot pushed a commit that referenced this pull request Sep 25, 2021
## Issue Addressed

N/A

## Proposed Changes

Add the new ContributionAndProof event: ethereum/beacon-APIs#158

## Additional Info

N/A

Co-authored-by: realbigsean <[email protected]>
@bors bors bot changed the title Add contribution and proof event [Merged by Bors] - Add contribution and proof event Sep 25, 2021
@bors bors bot closed this Sep 25, 2021
@realbigsean realbigsean deleted the contribution-and-proof-event branch November 21, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants