Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Block validation #24

Merged
merged 28 commits into from
Oct 2, 2018
Merged

[WIP] Block validation #24

merged 28 commits into from
Oct 2, 2018

Commits on Sep 26, 2018

  1. Add block validation code 

    This was created in another branch along with a whole bunch of other
commits building out databases and other common elements.

This full history of these works is available on master, however it
should not be necessary.
    @paulhauner
    paulhauner committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    9dcec21 View commit details
    Browse the repository at this point in the history

  2. Split block validation tests into functions

    @paulhauner
    paulhauner committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    84bb408 View commit details
    Browse the repository at this point in the history

  3. Add first block validation benches

    @paulhauner
    paulhauner committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    a8b08fb View commit details
    Browse the repository at this point in the history

  4. Move attestation validation into iter.for_each

    @paulhauner
    paulhauner committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    debc642 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2018

  1. Fix bug with bitfield validation

    @paulhauner
    paulhauner committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    05fe231 View commit details
    Browse the repository at this point in the history

  2. Add (untested) parallelization for att validation

    @paulhauner
    paulhauner committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    b92d88d View commit details
    Browse the repository at this point in the history

  3. Refact block val. tests to be more modular

    @paulhauner
    paulhauner committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    19ddbde View commit details
    Browse the repository at this point in the history

  4. Refactor block val. benches to use test funtions

    @paulhauner
    paulhauner committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    8020b89 View commit details
    Browse the repository at this point in the history

  5. Tidy benches file

    @paulhauner
    paulhauner committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    13467ab View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2018

  1. Tidy comments in block validation

    @paulhauner
    paulhauner committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    7c88f94 View commit details
    Browse the repository at this point in the history

  2. Introduce "benches" feature 

    So that benchmarks don't run each time tests run
    @paulhauner
    paulhauner committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    e0e8aa9 View commit details
    Browse the repository at this point in the history

  3. Further development on block validation 

    - Return a fully deserialized block from validate_ssz_block
- Ensure the parent_hash field is handled
    @paulhauner
    paulhauner committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    bc27be1 View commit details
    Browse the repository at this point in the history

  4. Refactor block val. into "BlockValidationContext"

    @paulhauner
    paulhauner committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    0b99951 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2018

  1. Rename block_store functions 

     - Specified that the block is "serialized".
    @paulhauner
    paulhauner committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    385564d View commit details
    Browse the repository at this point in the history

  2. Progress further with block validation 

    - Rename errors returned from SszBlock.
- Add parent_hash concept to block validation.
- Add more comments to block validation.
    @paulhauner
    paulhauner committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    5dd2361 View commit details
    Browse the repository at this point in the history

  3. Simplify block validation tests 

    Move more parameters into get_simple_params()
    @paulhauner
    paulhauner committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    9642c4b View commit details
    Browse the repository at this point in the history

  4. Fix bug in boolean bitfield 

    The length generated when converting from a string was incorrect.
    @paulhauner
    paulhauner committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    a87fe88 View commit details
    Browse the repository at this point in the history

  5. Fix bug in attestation val. bitfield checking 

    There was a logic error
    @paulhauner
    paulhauner committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    496adc0 View commit details
    Browse the repository at this point in the history

  6. Implement more tests for block validation

    @paulhauner
    paulhauner committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    77b48b9 View commit details
    Browse the repository at this point in the history

  7. Update benchmarks as per recent code changes

    @paulhauner
    paulhauner committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    29ed29c View commit details
    Browse the repository at this point in the history

  8. Remove "benches" feature 

    Now benches just live with the rest of the code in the default feature.
    @paulhauner
    paulhauner committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    b426c9e View commit details
    Browse the repository at this point in the history

  9. Introduce AttestationValidationContext 

    This reduced code duplication.
    @paulhauner
    paulhauner committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    c3ec8a3 View commit details
    Browse the repository at this point in the history

  10. Restructure block validation directory

    @paulhauner
    paulhauner committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    4d1f730 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2018

  1. Refactor validation tests into integration tests

    @paulhauner
    paulhauner committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    8f52858 View commit details
    Browse the repository at this point in the history

  2. Implement framework for testing attestation val.

    @paulhauner
    paulhauner committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    8e094b3 View commit details
    Browse the repository at this point in the history

  3. Update block and attestation validation code

    @paulhauner
    paulhauner committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    6b7677a View commit details
    Browse the repository at this point in the history

  4. Add test for attestation msg generation

    @paulhauner
    paulhauner committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    cd3b2f5 View commit details
    Browse the repository at this point in the history

  5. Add tests for attestation_validation

    @paulhauner
    paulhauner committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    07bfd7e View commit details
    Browse the repository at this point in the history