Use smallvec for bitvec for heapless attns #2182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to close this since I couldn't observe any measurable difference in CPU or memory usage. It seems like a nice change from a "mechanical sympathy" perspective, but I'm just not convinced it's worth it. |
paulhauner
added a commit
to paulhauner/lighthouse
that referenced
this pull request
Apr 13, 2021
commit 7f62b7c Author: Paul Hauner <[email protected]> Date: Mon Feb 1 11:23:58 2021 +1100 Use smallvec for bitfield
paulhauner
added a commit
to paulhauner/lighthouse
that referenced
this pull request
Apr 14, 2021
commit 7f62b7c Author: Paul Hauner <[email protected]> Date: Mon Feb 1 11:23:58 2021 +1100 Use smallvec for bitfield
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Use
SmallVec<[u8; 32]>forBitVecso thatAttestationobjects require zero heap allocations.Additional Info
TBC