Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tree hash update - added padding #198

Closed
wants to merge 2 commits into from

Conversation

mjkeating
Copy link
Contributor

Issue Addressed

Which issue # does this PR address?

#193

Please list or describe the changes introduced by this PR.

Adds padding according to spec

@paulhauner
Copy link
Member

Hi @mjkeating, very sorry for the inconvenience but could you please implement these changes here: https://github.com/sigp/lighthouse-common

If you'd like to see the rationale for this re-org, please see #197.

I promise we won't do this again for a while!

@paulhauner paulhauner closed this Feb 13, 2019
@paulhauner paulhauner reopened this Feb 14, 2019
@paulhauner
Copy link
Member

Sorry about the conflicts! Let me know if you need a hand to resolve :)

@paulhauner paulhauner changed the title Tree hash update - added padding [WIP] Tree hash update - added padding Feb 14, 2019
@paulhauner paulhauner added the work-in-progress PR is a work-in-progress label Feb 14, 2019
@paulhauner
Copy link
Member

@mjkeating should I close this in favor of #236, please?

@mjkeating
Copy link
Contributor Author

Yes, please close this PR in favor of #238

@AgeManning
Copy link
Member

Closed in favour of #238

@AgeManning AgeManning closed this Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress PR is a work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants