[Merged by Bors] - Update consensus code and tests to v0.12.3 #1655
Conversation
michaelsproul
added
work-in-progress
michaelsproul
changed the title
| @@ -642,10 +639,8 @@ impl YamlConfig { | |||
| } | |||
|
|
|||
| pub fn apply_to_chain_spec<T: EthSpec>(&self, chain_spec: &ChainSpec) -> Option<ChainSpec> { | |||
There was a problem hiding this comment.
I notice we don't check config_name in this function.
I think this is fine, it might be nice to name them different things but have the same values. IMO we don't really care about the name.
Happy to leave this as-is.
There was a problem hiding this comment.
Yeah, part of the problem with that would be backwards compatibility, the Altona and Medalla configs don't have the config_name param at all (I guess we could default to mainnet). But happy to leave as-is.
|
For the record, I've got the new v0.12.3 gossip verification conditions in a PR here: #1667. I could change the base for that PR to this branch, if we want an atomic merge. |
|
Thanks Paul! bors r+ |
## Proposed Changes Update test vectors for v0.12.3, and introduced configurable `proportional_slashing_multiplier`. Also makes `YamlConfig` a bit safer by making every field access in `apply_to_chain_spec` explicit, and removing the `#[serde(default)]` attribute, which would instantiate missing fields to type defaults! Risky!
michaelsproul
added
ready-for-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
michaelsproul
added
the
consensus
Proposed Changes
Update test vectors for v0.12.3, and introduced configurable
proportional_slashing_multiplier.Also makes
YamlConfiga bit safer by making every field access inapply_to_chain_specexplicit, and removing the#[serde(default)]attribute, which would instantiate missing fields to type defaults! Risky!