Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Revert "Update BLST, add force-adx support (#1595)" #1649

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Revert "Update BLST, add force-adx support (#1595)" #1649

wants to merge 1 commit into from

Conversation

michaelsproul
Copy link
Member

This reverts commit 4fca306.

Something in the BLST update is causing SIGILLs on aarch64 non-portable builds. While we debug the issue, I think it's best if we just revert the update.

@michaelsproul michaelsproul added low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review labels Sep 23, 2020
paulhauner
paulhauner approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Sep 23, 2020
@michaelsproul
Revert "Update BLST, add force-adx support (#1595)" (#1649)
62c8548 
This reverts commit 4fca306.

Something in the BLST update is causing SIGILLs on aarch64 non-portable builds. While we debug the issue, I think it's best if we just revert the update.
@paulhauner paulhauner added A0 ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Sep 23, 2020
@bors
Copy link

bors bot commented Sep 23, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Revert "Update BLST, add force-adx support (#1595)" [Merged by Bors] - Revert "Update BLST, add force-adx support (#1595)" Sep 23, 2020
@bors bors bot closed this Sep 23, 2020
@michaelsproul michaelsproul deleted the revert-blst-update branch September 23, 2020 01:43
This was referenced Oct 2, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @paulhauner