Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Eth1 network exit on wrong network id #1563

Closed
wants to merge 5 commits into from

Conversation

pawanjay176
Copy link
Member

Issue Addressed

Fixes #1509

Proposed Changes

Exit the beacon node if the eth1 endpoint points to an invalid eth1 network. Check the network id before every eth1 cache update and display an error log if the network id has changed to an invalid one.

@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Aug 25, 2020
@pawanjay176 pawanjay176 requested a review from paulhauner August 25, 2020 08:49
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

I guess at some point we will need to make this configurable to allow non-goerli networks.

@AgeManning
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 31, 2020
## Issue Addressed

Fixes #1509 

## Proposed Changes

Exit the beacon node if the eth1 endpoint points to an invalid eth1 network. Check the network id before every eth1 cache update and display an error log if the network id has changed to an invalid one.
@bors bors bot changed the title Eth1 network exit on wrong network id [Merged by Bors] - Eth1 network exit on wrong network id Aug 31, 2020
@bors bors bot closed this Aug 31, 2020
darcys22 pushed a commit to darcys22/lighthouse that referenced this pull request Sep 5, 2020
## Issue Addressed

Fixes sigp#1509 

## Proposed Changes

Exit the beacon node if the eth1 endpoint points to an invalid eth1 network. Check the network id before every eth1 cache update and display an error log if the network id has changed to an invalid one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit eth1 task on wrong network id
2 participants