Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete ExecutionOptimisticForkVersionedResponse #4146

Closed
michaelsproul opened this issue Mar 30, 2023 · 0 comments
Closed

Delete ExecutionOptimisticForkVersionedResponse #4146

michaelsproul opened this issue Mar 30, 2023 · 0 comments
Assignees
@macladson
Labels
code-quality HTTP-API

Comments

@michaelsproul
Copy link
Member

Description

After #3753 is merged the ExecutionOptimisticForkVersionedResponse type will be scarcely used. The only place it remains is get_debug_beacon_states_v1, which is deprecated and could be deleted 🎉

Steps to resolve

  • Remove ExecutionOptimisticForkVersionedResponse
  • Remove get_debug_beacon_states_v1 and the test that uses it
@macladson macladson self-assigned this Apr 3, 2023
@macladson macladson mentioned this issue Apr 3, 2023
Closed
bors bot pushed a commit that referenced this issue Apr 12, 2023
@macladson
Remove the unused ExecutionOptimisticForkVersionedResponse type (#4160
0e2e23e 
)

## Issue Addressed

#4146 

## Proposed Changes

Removes the `ExecutionOptimisticForkVersionedResponse` type and the associated Beacon API endpoint which is now deprecated. Also removes the test associated with the endpoint.
ghost pushed a commit to oone-world/lighthouse that referenced this issue Jul 13, 2023
@macladson
Remove the unused ExecutionOptimisticForkVersionedResponse type (si…
50151b0 
…gp#4160)

## Issue Addressed

sigp#4146 

## Proposed Changes

Removes the `ExecutionOptimisticForkVersionedResponse` type and the associated Beacon API endpoint which is now deprecated. Also removes the test associated with the endpoint.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@macladson @Woodpile37
Remove the unused ExecutionOptimisticForkVersionedResponse type (si…
7e4e606 
…gp#4160)

## Issue Addressed

sigp#4146 

## Proposed Changes

Removes the `ExecutionOptimisticForkVersionedResponse` type and the associated Beacon API endpoint which is now deprecated. Also removes the test associated with the endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macladson macladson

Labels
code-quality HTTP-API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @macladson