Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable block_lookup_failed EF test #3448

Closed
paulhauner opened this issue Aug 10, 2022 · 0 comments
Closed

Enable block_lookup_failed EF test #3448

paulhauner opened this issue Aug 10, 2022 · 0 comments
Assignees
Labels
bellatrix Required to support the Bellatrix Upgrade

Comments

@paulhauner
Copy link
Member

paulhauner commented Aug 10, 2022

Description

We are currently skipping an EF test:

// TODO(merge): re-enable this test before production.
// This test is skipped until we can do retrospective confirmations of the terminal
// block after an optimistic sync.
if self.description == "block_lookup_failed" {
return Err(Error::SkippedKnownFailure);
};

I haven't looked into this deeply, but I suspect that #3372 gives us what we need to re-enable this test!

CC'ing @ethDreamer since he might be interested ☺️

@paulhauner paulhauner added the bellatrix Required to support the Bellatrix Upgrade label Aug 10, 2022
@paulhauner paulhauner self-assigned this Aug 21, 2022
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
## Issue Addressed

Resolves sigp#3448

## Proposed Changes

Removes a known failure that wasn't actually a known failure. The tests declare this block invalid and we refuse to import it due to `ExecutionPayloadError(UnverifiedNonOptimisticCandidate)`.

This is correct since there is only one "eth1" block included in this test and two are required to trigger the merge (pre- and post-TTD blocks). It is slot 1 (tick = 12s) when this block is imported so the import must be prevented by `SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY`.

I'm not sure where I got the idea in sigp#3448 that this test needed retrospective checking, that seems like a false assumption in hindsight.

## Additional Info

- Blocked on sigp#3464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bellatrix Required to support the Bellatrix Upgrade
Projects
None yet
Development

No branches or pull requests

1 participant