You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
## Issue Addressed
Resolvessigp#3448
## Proposed Changes
Removes a known failure that wasn't actually a known failure. The tests declare this block invalid and we refuse to import it due to `ExecutionPayloadError(UnverifiedNonOptimisticCandidate)`.
This is correct since there is only one "eth1" block included in this test and two are required to trigger the merge (pre- and post-TTD blocks). It is slot 1 (tick = 12s) when this block is imported so the import must be prevented by `SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY`.
I'm not sure where I got the idea in sigp#3448 that this test needed retrospective checking, that seems like a false assumption in hindsight.
## Additional Info
- Blocked on sigp#3464
Description
We are currently skipping an EF test:
lighthouse/testing/ef_tests/src/cases/fork_choice.rs
Lines 159 to 164 in df51a73
I haven't looked into this deeply, but I suspect that #3372 gives us what we need to re-enable this test!
CC'ing @ethDreamer since he might be interested☺️
The text was updated successfully, but these errors were encountered: