-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace prometheus client with the official one #2956
Comments
In lighthouse, the client is used to:
The metrics is defined as Ethereum consensus client metrics and Beacon chain metrics. |
👋 Another benefit would be dependency consolidation. |
📝 I'm working on prometheus/client_rust#47. This makes the client able to do our the |
📝 I found out that lighthouse is using HistogramTimer, which is timer to measure and record the duration of an event. (e.g. here) For now, if I understand correctly, the official client doesn’t have a functionality equivalent to HistogramTimer. |
I find |
Description
Prometheus team have released an official Prometheus instrumentation library for Rust.
https://github.com/prometheus/client_rust
We're not having any problems with the current client for now, however, I believe we would take benefits from the official one. ref: tikv/rust-prometheus#392
The text was updated successfully, but these errors were encountered: