Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TreeHash to spec - add necessary padding #214

Closed
mjkeating opened this issue Feb 11, 2019 · 2 comments
Closed

Update TreeHash to spec - add necessary padding #214

mjkeating opened this issue Feb 11, 2019 · 2 comments
Assignees
Labels
spec_change A change related to the Eth2 spec work-started

Comments

@mjkeating
Copy link
Contributor

Please provide a brief description of the issue.

Needs necessary padding as per ethereum/consensus-specs#538

Describe the present behaviour of the application, with regards to this
issue.

Doesn't have padding

Steps to resolve

  1. Change current hash_tree_root to hash_tree_root_internal
  2. Add new hash_tree_root that pads result of hash_tree_root_internal to 32 bytes if necessary
  3. Add necessary padding within merkle_hash algorithm

See updated spec: https://github.com/ethereum/eth2.0-specs/blob/master/specs/simple-serialize.md#tree-hash

@mjkeating mjkeating changed the title Update TreeHash to spec Update TreeHash to spec - add necessary padding Feb 11, 2019
@mjkeating
Copy link
Contributor Author

I've started working on this.

@paulhauner
Copy link
Member

Moving to https://github.com/sigp/lighthouse-common

Apologies if the repo re-org has caused inconvenience! (See #197)

@paulhauner paulhauner transferred this issue from sigp/lighthouse Feb 13, 2019
@paulhauner paulhauner transferred this issue from another repository Feb 14, 2019
@paulhauner paulhauner added spec_change A change related to the Eth2 spec work-started labels Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec_change A change related to the Eth2 spec work-started
Projects
None yet
Development

No branches or pull requests

2 participants