Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcli --spec minimal interop-genesis creates a genesis state that isn't parse-able by lighthouse bn --spec minimal #1552

Closed
lsankar4033 opened this issue Aug 20, 2020 · 1 comment

Comments

@lsankar4033
Copy link

Description

Using lcli --spec minimal interop-genesis creates a genesis state that isn't parsed by lighthouse bn --spec minimal. I'm using the minimal spec for testing purposes.

lcli --spec mainnet interop-genesis does work as expected.

Version

master ebb25b5

Present Behaviour

➜  sandbox lcli --spec minimal new-testnet --testnet-dir ./testnet --deposit-contract-address 0000000000000000000000000000000000000000 && \
lcli --spec minimal interop-genesis --testnet-dir ./testnet 64 && \
lighthouse bn --testnet-dir ./testnet --spec minimal
Unable to parse genesis state: OffsetIntoFixedPortion(0)

Expected Behaviour

I expect the beacon node to start up with a minimal genesis state.

bors bot pushed a commit that referenced this issue Aug 21, 2020
## Issue Addressed

Fixes #1552 

## Proposed Changes

Earlier, we were always loading the hardcoded default testnet config which is a mainnet spec. So running lighthouse with `--spec` option anything other than mainnet gave errors because we tried loading a mainnet genesis spec with `minimal`/`interop` flags.

This PR fixes the order of loading such that we load the hardcoded default spec only if neither `--testnet` and `--testnet-dir` flags are present.
@bors bors bot closed this as completed in 175471a Aug 25, 2020
@lsankar4033
Copy link
Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant