Skip to content

Commit

Permalink
Downgrade Geth to v1.10.20 in EE integration tests (#3382)
Browse files Browse the repository at this point in the history
## Issue Addressed

NA

## Proposed Changes

The execution integration tests have started failing since Geth updated to v1.10.21. More details here: ethereum/go-ethereum#25427 (comment)

This PR pins our version at v1.10.20.

## Additional Info

NA
  • Loading branch information
paulhauner committed Jul 28, 2022
1 parent 736b913 commit a0563d4
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions testing/execution_engine_integration/src/geth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use std::{env, fs::File};
use tempfile::TempDir;
use unused_port::unused_tcp_port;

const GETH_BRANCH: &str = "master";
// const GETH_BRANCH: &str = "master";
const GETH_REPO_URL: &str = "https://github.com/ethereum/go-ethereum";

pub fn build_result(repo_dir: &Path) -> Output {
Expand All @@ -26,8 +26,13 @@ pub fn build(execution_clients_dir: &Path) {
build_utils::clone_repo(execution_clients_dir, GETH_REPO_URL).unwrap();
}

// TODO: this should be set back to the latest release once the following issue is resolved:
//
// - https://github.com/ethereum/go-ethereum/issues/25427
//
// Get the latest tag on the branch
let last_release = build_utils::get_latest_release(&repo_dir, GETH_BRANCH).unwrap();
// let last_release = build_utils::get_latest_release(&repo_dir, GETH_BRANCH).unwrap();
let last_release = "v1.10.20";
build_utils::checkout(&repo_dir, dbg!(&last_release)).unwrap();

// Build geth
Expand Down

0 comments on commit a0563d4

Please sign in to comment.