Skip to content

Commit

Permalink
Make lighthouse_version compatible with old Git (#2223)
Browse files Browse the repository at this point in the history
## Proposed Changes

When building the release binaries with Cross, Ubuntu 16.04 is used, which uses an old verison of Git lacking support for `--exclude`. This PR changes `lighthouse_version` to use `--match` instead.
  • Loading branch information
michaelsproul committed Feb 24, 2021
1 parent afd4786 commit 0b2ccec
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion common/lighthouse_version/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,13 @@ use target_info::Target;
///
/// `Lighthouse/v0.2.0-1419501f2+`
pub const VERSION: &str = git_version!(
args = ["--always", "--dirty=+", "--abbrev=7", "--exclude=*"],
args = [
"--always",
"--dirty=+",
"--abbrev=7",
// NOTE: using --match instead of --exclude for compatibility with old Git
"--match=thiswillnevermatchlol"
],
prefix = "Lighthouse/v1.1.3-",
fallback = "unknown"
);
Expand Down

0 comments on commit 0b2ccec

Please sign in to comment.