Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Update aes-gcm to 0.10.3 and aes to 0.8.4 #261

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

kevaundray
Copy link
Contributor

Description

This PR updates aes-gcm and is related to #260

Notes & open questions

Change checklist

  • Self-review
  • Documentation updates if relevant
  • Tests if relevant

@kevaundray kevaundray changed the title chore!: Update aes-gcm to 0.10.3 chore!: Update aes-gcm to 0.10.3 and aes to 0.8.4 Aug 19, 2024
@michaelsproul michaelsproul requested a review from jxs August 20, 2024 00:33
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Tests are passing locally but I'll need a maintainer to enable CI and approve

Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Michael Sproul <[email protected]>
@kevaundray
Copy link
Contributor Author

The clippy errors are orthogonal to this PR -- have fixed them in: #262

Copy link
Member

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AgeManning AgeManning merged commit 8609864 into sigp:master Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants