Skip to content

Commit

Permalink
fix rename ForeignKey when changin Schema
Browse files Browse the repository at this point in the history
  • Loading branch information
olmobrutall committed Dec 11, 2018
1 parent a211159 commit 8d81a5f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Signum.Engine/Engine/SchemaSynchronizer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ from c in t.Columns.Values

var name = SqlBuilder.ForeignKeyName(tab.Name.Name, colModel.Name);
return SqlPreCommand.Combine(Spacing.Simple,
name != coldb.ForeignKey.Name.Name ? SqlBuilder.RenameForeignKey(coldb.ForeignKey.Name, name) : null,
name != coldb.ForeignKey.Name.Name ? SqlBuilder.RenameForeignKey(coldb.ForeignKey.Name.OnSchema(tab.Name.Schema), name) : null,
(coldb.ForeignKey.IsDisabled || coldb.ForeignKey.IsNotTrusted) && !replacements.SchemaOnly ? SqlBuilder.EnableForeignKey(tab.Name, name) : null);
})
);
Expand Down

3 comments on commit 8d81a5f

@olmobrutall
Copy link
Collaborator Author

@olmobrutall olmobrutall commented on 8d81a5f Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Animated Charts

After this commit signumsoftware/extensions@d6dd0d0 in extensions, the charts are now animated 🎉 💃 🎈

This includes:

  • A small animation when the first chart is loaded.
  • Transition animations when the parameters, the query tokens, or even the chart type changes.

Of course I haven't developed every animation by myself, there are zillions of combinations!!. What I do is to rely on React's reconciliation algorithm and CSS transitions.

I haven't tested with big amounts of data. Gimme feedback of when is slow, so I can automatically disable it depending on the number of rows.

Enjoy :)

@KonstantinLukaschenko
Copy link
Contributor

@KonstantinLukaschenko KonstantinLukaschenko commented on 8d81a5f Dec 11, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MehdyKarimpour
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Please sign in to comment.