update to VS 16.3

Signum.Engine/Basics/ExceptionLogic.cs

@@ -14,8 +14,6 @@ namespace Signum.Engine.Basics
 {
 	public static class ExceptionLogic
 	{
-		public static Func<string> GetCurrentVersion;
-
 		public static void Start(SchemaBuilder sb)
 		{
 			if (sb.NotDefined(MethodInfo.GetCurrentMethod()))
@@ -111,21 +109,21 @@ static ExceptionEntity SaveForceNew(this ExceptionEntity entity)
 			}
 		}
 
-		public static string DefaultEnvironment { get; set; }
+		public static string? DefaultEnvironment { get; set; }
 
-		public static string CurrentEnvironment { get { return overridenEnvironment.Value ?? DefaultEnvironment; } }
+		public static string? CurrentEnvironment { get { return overridenEnvironment.Value ?? DefaultEnvironment; } }
 
-		static readonly Variable<string> overridenEnvironment = Statics.ThreadVariable<string>("exceptionEnviroment");
+		static readonly Variable<string?> overridenEnvironment = Statics.ThreadVariable<string?>("exceptionEnviroment");
 
-		public static IDisposable OverrideEnviroment(string newEnviroment)
+		public static IDisposable OverrideEnviroment(string? newEnviroment)
 		{
-			string oldEnviroment = overridenEnvironment.Value;
+			string? oldEnviroment = overridenEnvironment.Value;
 			overridenEnvironment.Value = newEnviroment;
 			return new Disposable(() => overridenEnvironment.Value = oldEnviroment);
 		}
 
 
-		public static event Action<DeleteLogParametersEmbedded, StringBuilder, CancellationToken> DeleteLogs;
+		public static event Action<DeleteLogParametersEmbedded, StringBuilder, CancellationToken>? DeleteLogs;
 
 		public static int DeleteLogsTimeOut = 10 * 60 * 1000;
 

Signum.Engine/Basics/PropertyRouteLogic.cs

@@ -16,7 +16,7 @@ public static class PropertyRouteLogic
         public static bool IsPropertyRoute(this PropertyRouteEntity prdn, PropertyRoute pr) =>
             As.Expression(() => prdn.RootType == pr.RootType.ToTypeEntity() && prdn.Path == pr.PropertyString());
 
-        public static ResetLazy<Dictionary<TypeEntity, Dictionary<string, PropertyRouteEntity>>> Properties;
+        public static ResetLazy<Dictionary<TypeEntity, Dictionary<string, PropertyRouteEntity>>> Properties = null!;
 
         public static void Start(SchemaBuilder sb)
         {

Signum.Engine/Basics/QueryLogic.cs

@@ -14,10 +14,10 @@ namespace Signum.Engine.Basics
 {
     public static class QueryLogic
     {
-        static ResetLazy<Dictionary<string, object>> queryNamesLazy;
+        static ResetLazy<Dictionary<string, object>> queryNamesLazy = null!;
         public static Dictionary<string, object> QueryNames => queryNamesLazy.Value;
 
-        static ResetLazy<Dictionary<object, QueryEntity>> queryNameToEntityLazy;
+        static ResetLazy<Dictionary<object, QueryEntity>> queryNameToEntityLazy = null!;
         public static Dictionary<object, QueryEntity> QueryNameToEntity => queryNameToEntityLazy.Value;
 
         public static DynamicQueryContainer Queries { get; } = new DynamicQueryContainer();

Signum.Engine/Basics/SemiSymbolLogic.cs

@@ -11,8 +11,8 @@ namespace Signum.Engine.Extensions.Basics
     public static class SemiSymbolLogic<T>
         where T : SemiSymbol
     {
-        static ResetLazy<Dictionary<string, T>> lazy;
-        static Func<IEnumerable<T>> getSemiSymbols;
+        static ResetLazy<Dictionary<string, T>> lazy = null!;
+        static Func<IEnumerable<T>> getSemiSymbols = null!;
 
         [ThreadStatic]
         static bool avoidCache;

Signum.Engine/Basics/SymbolLogic.cs

@@ -12,7 +12,7 @@ namespace Signum.Engine
 
     public static class SymbolLogic
     {
-        public static event Action OnLoadAll;
+        public static event Action? OnLoadAll;
 
         public static void LoadAll()
         {
@@ -23,8 +23,8 @@ public static void LoadAll()
     public static class SymbolLogic<T>
         where T: Symbol
     {
-        static ResetLazy<Dictionary<string, T>> lazy;
-        static Func<IEnumerable<T>> getSymbols;
+        static ResetLazy<Dictionary<string, T>> lazy = null!;
+        static Func<IEnumerable<T>> getSymbols = null!;
 
         [ThreadStatic]
         static bool avoidCache;

Signum.Engine/Connection/Connector.cs

@@ -33,7 +33,7 @@ public static Connector Current
             get { return currentConnector.Value ?? Default; }
         }
 
-        static Connector @default;
+        static Connector @default = null!;
         public static Connector Default
         {
             get { return @default; }

Signum.Engine/Connection/Transaction.cs

@@ -24,9 +24,9 @@ public class Transaction : IDisposableException
 
         interface ICoreTransaction
         {
-            event Action<Dictionary<string, object>?> PostRealCommit;
+            event Action<Dictionary<string, object>?>? PostRealCommit;
             void CallPostRealCommit();
-            event Action<Dictionary<string, object>?> PreRealCommit;
+            event Action<Dictionary<string, object>?>? PreRealCommit;
             DbConnection? Connection { get; }
             DbTransaction? Transaction { get; }
 
@@ -60,13 +60,13 @@ public FakedTransaction(ICoreTransaction parent)
                 this.parent = parent;
             }
 
-            public event Action<Dictionary<string, object>?> PostRealCommit
+            public event Action<Dictionary<string, object>?>? PostRealCommit
             {
                 add { parent.PostRealCommit += value; }
                 remove { parent.PostRealCommit -= value; }
             }
 
-            public event Action<Dictionary<string, object>?> PreRealCommit
+            public event Action<Dictionary<string, object>?>? PreRealCommit
             {
                 add { parent.PreRealCommit += value; }
                 remove { parent.PreRealCommit -= value; }
@@ -118,9 +118,9 @@ class RealTransaction : ICoreTransaction
             public DbTransaction? Transaction { get; private set; }
             public Exception? IsRolledback { get; private set; }
             public bool Started { get; private set; }
-            public event Action<Dictionary<string, object>?> PostRealCommit;
-            public event Action<Dictionary<string, object>?> PreRealCommit;
-            public event Action<Dictionary<string, object>?> Rolledback;
+            public event Action<Dictionary<string, object>?>? PostRealCommit;
+            public event Action<Dictionary<string, object>?>? PreRealCommit;
+            public event Action<Dictionary<string, object>?>? Rolledback;
 
             IsolationLevel? IsolationLevel;
 
@@ -219,10 +219,10 @@ class NamedTransaction : ICoreTransaction
             string savePointName;
             public Exception? IsRolledback { get; private set; }
             public bool Started { get; private set; }
-            public event Action<Dictionary<string, object>?> PostRealCommit;
+            public event Action<Dictionary<string, object>?>? PostRealCommit;
 
-            public event Action<Dictionary<string, object>?> PreRealCommit;
-            public event Action<Dictionary<string, object>?> Rolledback;
+            public event Action<Dictionary<string, object>?>? PreRealCommit;
+            public event Action<Dictionary<string, object>?>? Rolledback;
 
             public NamedTransaction(ICoreTransaction parent, string savePointName)
             {
@@ -297,9 +297,9 @@ class NoneTransaction : ICoreTransaction
             public DbTransaction? Transaction { get { return null; } }
             public Exception? IsRolledback { get; private set; }
             public bool Started { get; private set; }
-            public event Action<Dictionary<string, object>?> PostRealCommit;
-            public event Action<Dictionary<string, object>?> PreRealCommit;
-            public event Action<Dictionary<string, object>?> Rolledback;
+            public event Action<Dictionary<string, object>?>? PostRealCommit;
+            public event Action<Dictionary<string, object>?>? PreRealCommit;
+            public event Action<Dictionary<string, object>?>? Rolledback;
 
             public NoneTransaction(ICoreTransaction? parent)
             {

Signum.Engine/DynamicQuery/DynamicQueryContainer.cs

@@ -102,7 +102,7 @@ async Task<T> ExecuteAsync<T>(ExecuteType executeType, object queryName, BaseQue
             }
         }
 
-        public event Func<ExecuteType, object, BaseQueryRequest?, IDisposable?> QueryExecuted;
+        public event Func<ExecuteType, object, BaseQueryRequest?, IDisposable?>? QueryExecuted;
 
         public enum ExecuteType
         {
@@ -166,7 +166,7 @@ public DQueryable<object> GetDQueryable(DQueryableRequest request)
             return Execute(ExecuteType.GetDQueryable, request.QueryName, null, dqb => dqb.Core.Value.GetDQueryable(request));
         }
 
-        public event Func<object, bool, bool> AllowQuery;
+        public event Func<object, bool, bool>? AllowQuery;
 
         public bool QueryAllowed(object queryName, bool fullScreen)
         {

Signum.Engine/Engine/SchemaSynchronizer.cs

@@ -16,7 +16,7 @@ public static class SchemaSynchronizer
     {
         public static Func<SchemaName, bool> DropSchema = s => !s.Name.Contains(@"\");
 
-        public static Action<Dictionary<string, DiffTable>> SimplifyDiffTables;
+        public static Action<Dictionary<string, DiffTable>>? SimplifyDiffTables;
 
         public static SqlPreCommand? SynchronizeTablesScript(Replacements replacements)
         {

Signum.Engine/Engine/SqlBuilder.cs

@@ -367,9 +367,9 @@ public static int DuplicateCount(UniqueIndex uniqueIndex, Replacements rep)
 (
     SELECT MIN({oldPrimaryKey})
     FROM {oldTableName}
-    {(string.IsNullOrWhiteSpace(uniqueIndex.Where) ? "" : "WHERE " + uniqueIndex.Where.Replace(columnReplacement))}
+    {(!uniqueIndex.Where.HasText() ? "" : "WHERE " + uniqueIndex.Where.Replace(columnReplacement))}
     GROUP BY {oldColumns}
-){(string.IsNullOrWhiteSpace(uniqueIndex.Where) ? "" : "AND " + uniqueIndex.Where.Replace(columnReplacement))}")!;
+){(!uniqueIndex.Where.HasText() ? "" : "AND " + uniqueIndex.Where.Replace(columnReplacement))}")!;
         }
 
         public static SqlPreCommand? RemoveDuplicatesIfNecessary(UniqueIndex uniqueIndex, Replacements rep)

Signum.Engine/Engine/Synchronizer.cs

@@ -327,7 +327,7 @@ public AutoReplacementContext(string replacementKey, string oldValue, List<strin
             }
         }
 
-        public static Func<AutoReplacementContext, Selection?> AutoReplacement;
+        public static Func<AutoReplacementContext, Selection?>? AutoReplacement;
 
         private static Selection SelectInteractive(string oldValue, List<string> newValues, string replacementsKey, bool interactive)
         {

Signum.Engine/EntityCache.cs

@@ -195,7 +195,7 @@ public static T Construct<T>(PrimaryKey id) where T : Entity
 
         static class Constructor<T> where T : Entity
         {
-            static Func<T> call;
+            static Func<T>? call;
             public static Func<T> Call
             {
                 get

Signum.Engine/Linq/AliasGenerator.cs

@@ -46,7 +46,7 @@ public Alias NextTableAlias(string tableName)
             string? abv = tableName.Any(char.IsUpper) ? new string(tableName.Where(c => char.IsUpper(c)).ToArray()) :
                 tableName.Any(a => a == '_') ? new string(tableName.SplitNoEmpty('_' ).Select(s => s[0]).ToArray()) : null;
 
-            if (string.IsNullOrEmpty(abv))
+            if (!abv.HasText())
                 abv = tableName.TryStart(3)!;
             else
                 abv = abv.ToLower();

Signum.Engine/Operations/GraphState.cs

@@ -281,7 +281,7 @@ protected Graph()
             throw new InvalidOperationException("OperationGraphs should not be instantiated");
         }
 
-        static Expression<Func<T, S>> getState;
+        static Expression<Func<T, S>> getState = null!;
         public static Expression<Func<T, S>> GetState
         {
             get { return getState; }
@@ -292,11 +292,11 @@ public static Expression<Func<T, S>> GetState
             }
         }
 
-        public static Func<T, S> GetStateFunc{get; private set;}
+        public static Func<T, S> GetStateFunc { get; private set; } = null!;
 
 
-        public static Action<T, S> EnterState { get; set; }
-        public static Action<T, S> ExitState { get; set; }
+        public static Action<T, S>? EnterState { get; set; }
+        public static Action<T, S>? ExitState { get; set; }
 
 
 

Signum.Engine/Operations/OperationLogic.cs

@@ -205,8 +205,8 @@ static void EntityEventsGlobal_Saving(Entity ident)
 
         #region Events
 
-        public static event SurroundOperationHandler SurroundOperation;
-        public static event AllowOperationHandler AllowOperation;
+        public static event SurroundOperationHandler? SurroundOperation;
+        public static event AllowOperationHandler? AllowOperation;
 
         internal static IDisposable? OnSuroundOperation(IOperation operation, OperationLogEntity log, IEntity? entity, object[]? args)
         {

Signum.Engine/Schema/EntityEvents.cs

@@ -12,24 +12,24 @@ namespace Signum.Engine.Maps
     public class EntityEvents<T> : IEntityEvents
             where T : Entity
     {
-        public event PreSavingEventHandler<T> PreSaving;
-        public event SavingEventHandler<T> Saving;
-        public event SavedEventHandler<T> Saved;
+        public event PreSavingEventHandler<T>? PreSaving;
+        public event SavingEventHandler<T>? Saving;
+        public event SavedEventHandler<T>? Saved;
 
-        public event AlternativeRetriveEventHandler<T> AlternativeRetrive;
-        public event RetrievedEventHandler<T> Retrieved;
+        public event AlternativeRetriveEventHandler<T>? AlternativeRetrive;
+        public event RetrievedEventHandler<T>? Retrieved;
 
         public CacheControllerBase<T>? CacheController { get; set; }
 
-        public event FilterQueryEventHandler<T> FilterQuery;
+        public event FilterQueryEventHandler<T>? FilterQuery;
 
-        public event PreUnsafeDeleteHandler<T> PreUnsafeDelete;
-        public event PreUnsafeMListDeleteHandler<T> PreUnsafeMListDelete;
+        public event PreUnsafeDeleteHandler<T>? PreUnsafeDelete;
+        public event PreUnsafeMListDeleteHandler<T>? PreUnsafeMListDelete;
 
-        public event PreUnsafeUpdateHandler<T> PreUnsafeUpdate;
+        public event PreUnsafeUpdateHandler<T>? PreUnsafeUpdate;
 
-        public event PreUnsafeInsertHandler<T> PreUnsafeInsert;
-        public event BulkInsetHandler<T> PreBulkInsert;
+        public event PreUnsafeInsertHandler<T>? PreUnsafeInsert;
+        public event BulkInsetHandler<T>? PreBulkInsert;
 
         public Dictionary<PropertyRoute, IAdditionalBinding>? AdditionalBindings { get; private set; }
 

Signum.Engine/Schema/ObjectName.cs

@@ -50,7 +50,7 @@ public override int GetHashCode()
 
         public static ServerName? Parse(string? name)
         {
-            if (string.IsNullOrEmpty(name))
+            if (!name.HasText())
                 return null;
 
             return new ServerName(name.UnScapeSql());
@@ -103,7 +103,7 @@ public override int GetHashCode()
 
         public static DatabaseName? Parse(string? name)
         {
-            if (string.IsNullOrEmpty(name))
+            if (!name.HasText())
                 return null;
 
             var tuple = ObjectName.SplitLast(name);
@@ -174,7 +174,7 @@ public override int GetHashCode()
 
         public static SchemaName Parse(string? name)
         {
-            if (string.IsNullOrEmpty(name))
+            if (!name.HasText())
                 return SchemaName.Default;
 
             var tuple = ObjectName.SplitLast(name);
@@ -220,7 +220,7 @@ public override int GetHashCode()
 
         public static ObjectName Parse(string? name)
         {
-            if (string.IsNullOrEmpty(name))
+            if (!name.HasText())
                 throw new ArgumentNullException(nameof(name));
 
             var tuple = SplitLast(name);

Signum.Engine/Schema/Schema.cs

@@ -36,7 +36,7 @@ public Version Version
             set { this.version = value; }
         }
 
-        public event Action OnMetadataInvalidated;
+        public event Action? OnMetadataInvalidated;
         public void InvalidateMetadata()
         {
             this.OnMetadataInvalidated?.Invoke();
@@ -66,7 +66,7 @@ public Dictionary<Type, Table> Tables
 
         #region Events
 
-        public event Func<Type, bool, string?> IsAllowedCallback;
+        public event Func<Type, bool, string?>? IsAllowedCallback;
 
         public string? IsAllowed(Type type, bool inUserInterface)
         {

Signum.Engine/Schema/UniqueIndex.cs

@@ -99,7 +99,7 @@ public string? ViewName
         {
             get
             {
-                if (string.IsNullOrEmpty(Where))
+                if (!Where.HasText())
                     return null;
 
                 if (Connector.Current.AllowsIndexWithWhere(Where))

Signum.Entities/Basics/IUserEntity.cs

@@ -1,4 +1,4 @@
-using Signum.Utilities;
+using Signum.Utilities;
 using System;
 
 namespace Signum.Entities.Basics
@@ -10,7 +10,7 @@ public interface IUserEntity : IEntity
     public static class UserHolder
     {
         public static readonly string UserSessionKey = "user";
-        public static event Action CurrentUserChanged;
+        public static event Action? CurrentUserChanged;
 
         public static readonly SessionVariable<IUserEntity> CurrentUserVariable = Statics.SessionVariable<IUserEntity>(UserSessionKey);
         public static IUserEntity Current

Signum.Entities/DynamicQuery/ResultTable.cs

@@ -468,6 +468,6 @@ public T GetValue<T>(ResultColumn column)
             return result;
         }
 
-        public event PropertyChangedEventHandler PropertyChanged;
+        public event PropertyChangedEventHandler? PropertyChanged;
     }
 }

Signum.Entities/DynamicQuery/Tokens/ExtensionToken.cs

@@ -70,7 +70,7 @@ protected override List<QueryToken> SubTokensOverride(SubTokensOptions options)
             return base.SubTokensBase(type, options, implementations);
         }
 
-        public static Func<Type, string, Expression, Expression> BuildExtension;
+        public static Func<Type, string, Expression, Expression>? BuildExtension;
 
         protected override Expression BuildExpressionInternal(BuildExpressionContext context)
         {