upgrade Signum.Analyzer to 2.0 with nullability temp fix

signumsoftware · Apr 7, 2019 · 2cbf5c9 · 2cbf5c9 · olmobrutall · Apr 8, 2019
1 parent 5c1200c
commit 2cbf5c9
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 9 deletions.
diff --git a/Signum.Analyzer/Signum.Analyzer.Test/ExpressionFieldTest.cs b/Signum.Analyzer/Signum.Analyzer.Test/ExpressionFieldTest.cs
@@ -190,6 +190,15 @@ public void ExpressionExplicitCorrect()
         public static int OperationLogs(this Entity e) => 0;", includeExpression: true);
         }
 
+        [TestMethod]
+        public void ExpressionExplicitCorrectNullable()
+        {
+            TestDiagnostic(null, @"
+        static Expression<Func<Entity, string?>> MyExpression;        
+        [ExpressionField(""MyExpression"")]
+        public static string? OperationLogs(this Entity e) => """";", includeExpression: true);
+        }
+
 
         private void TestDiagnostic(string expectedError, string code, bool includeExpression = false, bool staticClass = true, bool assertErrors = true)
         {

diff --git a/Signum.Analyzer/Signum.Analyzer.Test/LiteEqualiyTest.cs b/Signum.Analyzer/Signum.Analyzer.Test/LiteEqualiyTest.cs
@@ -20,7 +20,7 @@ protected override DiagnosticAnalyzer GetCSharpDiagnosticAnalyzer()
         [TestMethod]
         public void CompareLiteAndEntity()
         {
-            TestDiagnostic("Impossible to compare Lite<T> and T. Consider using RefersTo method", @"
+            TestDiagnostic("Impossible to compare Lite<T> and T. Consider using 'Is' extension method", @"
 Lite<Entity> lite = null;
 Entity entity = null;
 var condition = lite == entity;       

diff --git a/Signum.Analyzer/Signum.Analyzer/ExpressionFieldAnalyzer.cs b/Signum.Analyzer/Signum.Analyzer/ExpressionFieldAnalyzer.cs
@@ -96,7 +96,8 @@ static void AnalyzeAttributeSymbol(SyntaxNodeAnalysisContext context)
 
                     if (!expressionType.Equals(fieldSymbol.Type))
                     {
-                        //if (!expressionType.ToString().Equals(fieldSymbol.Type.ToString())) // Till there is an API to express nullability
+                        if (!expressionType.ToString().Replace("?", "").Equals(
+                            fieldSymbol.Type.ToString().Replace("?", ""))) // Till there is an API to express nullability
                         {
                             var minimalParts = expressionType.ToMinimalDisplayString(context.SemanticModel, member.GetLocation().SourceSpan.Start);
                             Diagnostic(context, ident, att.GetLocation(), string.Format("type of '{0}' should be '{1}'", fieldName, minimalParts));

diff --git a/Signum.Analyzer/Signum.Analyzer/Signum.Analyzer.csproj b/Signum.Analyzer/Signum.Analyzer/Signum.Analyzer.csproj
@@ -8,7 +8,7 @@
 
   <PropertyGroup>
     <PackageId>Signum.Analyzer</PackageId>
-    <PackageVersion>2.0.0-beta</PackageVersion>
+    <PackageVersion>2.0.0</PackageVersion>
     <Authors>Olmo del Corral</Authors>
     <PackageProjectUrl>http://www.signumframework.com</PackageProjectUrl>
     <RepositoryUrl>https://github.com/signumsoftware/framework</RepositoryUrl>
@@ -17,9 +17,10 @@
     <Copyright></Copyright>
     <PackageTags>Signum.Analyzer, analyzers</PackageTags>
     <NoPackageAnalysis>true</NoPackageAnalysis>
-    <PackageLicenseUrl>https://opensource.org/licenses/MIT</PackageLicenseUrl>
-    <Version>2.0.0-beta</Version>
+    <PackageLicenseUrl></PackageLicenseUrl>
+    <Version>2.0.0</Version>
     <PackageIconUrl>https://raw.githubusercontent.com/signumsoftware/framework/master/SignumLogo.png</PackageIconUrl>
+    <PackageLicenseExpression>MIT</PackageLicenseExpression>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/Signum.Engine/Signum.Engine.csproj b/Signum.Engine/Signum.Engine.csproj
@@ -10,7 +10,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Signum.Analyzer" Version="1.0.1" />
+    <PackageReference Include="Signum.Analyzer" Version="2.0.0" />
     <PackageReference Include="Signum.MSBuildTask" Version="1.0.3" />
   </ItemGroup>
 

diff --git a/Signum.Entities/Signum.Entities.csproj b/Signum.Entities/Signum.Entities.csproj
@@ -10,7 +10,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Signum.Analyzer" Version="1.0.1" />
+    <PackageReference Include="Signum.Analyzer" Version="2.0.0" />
     <PackageReference Include="Signum.MSBuildTask" Version="1.0.3" />
   </ItemGroup>
 

diff --git a/Signum.React/Signum.React.csproj b/Signum.React/Signum.React.csproj
@@ -26,7 +26,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Signum.Analyzer" Version="1.0.1" />
+    <PackageReference Include="Signum.Analyzer" Version="2.0.0" />
     <PackageReference Include="Signum.TSGenerator" Version="2.0.1" />
   </ItemGroup>
 

diff --git a/Signum.Test/Signum.Test.csproj b/Signum.Test/Signum.Test.csproj
@@ -20,7 +20,7 @@
     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.2.0" />
     <PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="2.2.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.0.1" />
-    <PackageReference Include="Signum.Analyzer" Version="1.0.1" />
+    <PackageReference Include="Signum.Analyzer" Version="2.0.0" />
     <PackageReference Include="xunit" Version="2.4.1" /> 
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1">
       <PrivateAssets>all</PrivateAssets>