-
Notifications
You must be signed in to change notification settings - Fork 85
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge remote-tracking branch 'AlejandroCano/O365' into bootstrap5
# Conflicts: # Signum.React.Extensions/Mailing/MailingClient.tsx # Signum.React.Extensions/Workflow/WorkflowClient.tsx
- Loading branch information
Showing
19 changed files
with
283 additions
and
206 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
002bcc9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operation executing
Thanks to @mapacheL, this change solves one recurrent problem with Operation buttons: The UI is fully active while executing an operation.
Particularly I never liked to show a full-screen loading spinner that prevents UI interactions while waiting for the server, but this led to three potential problems:
ConcurrencyException
for saved entities, or either aUniqueKeyException
or a duplicated entity for new entities.This change prevents both errors: While the operation is executing all the other operation buttons will do a NO-OP while clicking (they are not disable for now) and the full entity UI gets
opacity: .7
indicating that the entity as you see it will soon be replaced by the version coming from the server (typically just a short blink).How to update
In order to change this behavior the UI needs to know when the operation has finished executing, so many methods are now returning
Promise<void>
instead ofvoid
:EntityOperationSettings<T>.onClick
EntityOperationContext<T>.defaultClick
ContextualOperationSettings<T>.onClick
ContextualOperationContext<T>.defaultContextualClick
There is a Signum.Upgrade,
Upgrade_20211111_ReplaceDefaultExecute
but it's definitely very optimistic only fixing like 10% of the operation overrides. You will need to fix most (all?) of them manually.002bcc9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.