Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Update #839

Closed
wants to merge 4 commits into from
Closed

Conversation

gittrekt
Copy link

Updated action CI/CD

  • Added building for amd64/arm64
  • Added build on tag version push
  • Fixed depreciated actions usage
  • Added docker build-cache for build speed improvement (maybe we could move this to a seperate docker repo?)

- Update deprecated workflows
- Update build platform for arm64 builds

Signed-off-by: gittrekt <[email protected]>
@gittrekt gittrekt requested a review from jjos2372 as a code owner November 17, 2024 22:41
@gittrekt
Copy link
Author

A few points to mention:

  1. When a new tag is pushed it must be in the format v0.0.0 (same as we currently do.) The docker release will be named as that tag, and latest
  2. Running workflow dispatch will release as the same name as branch (ex: main or develop)
  3. A buildcache image is also generated and uploaded. Future builds that don't have fundamental system changes will build much faster. (Note that alpine apk updates may cause a forced full rebuild.) The buildcache could be placed under it's own repo and any other future things we build with github actions in docker could also be placed under that repo with a different tag.

Copy link
Member

@ohager ohager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - maybe at least some docs update for deployment, would be nice

workflow_dispatch:
push:
tags:
- 'v*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I created the workflow, I was a bit hesitant to use a required tag format, as it was not 100% established flow.. And I'm still a bit hesitant...although, I consider this as good practice. jfyi - We should

  1. describe the exact deployment flow in the docs
  2. Maybe introduce a bash/batch script release.sh --minor or something for consistent runs

Copy link
Author

@gittrekt gittrekt Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version tags work very well at this point. I think it should be good for this use case.

The runs should be consistent other than workflow_dispatch. I can take a second look and maybe see if we can use consistent naming in workflow_dispatch case to also use version tags. I have a few private repos that use them without problems, assuming the right release tags are used (v0.0.0 or v0.0.0-RC1).

I can throw comments in. I'm always bad at documentation 😆

.github/workflows/dockerhub.yml Show resolved Hide resolved
@gittrekt gittrekt force-pushed the github branch 2 times, most recently from 153bd04 to 2021078 Compare November 26, 2024 15:09
@gittrekt gittrekt closed this Nov 26, 2024
@gittrekt gittrekt deleted the github branch November 26, 2024 16:23
@gittrekt gittrekt restored the github branch November 26, 2024 16:24
@gittrekt
Copy link
Author

I had to rename my branch due to a conflict. Will have to open new PR. @ohager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants