-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions Update #839
Conversation
- Update deprecated workflows - Update build platform for arm64 builds Signed-off-by: gittrekt <[email protected]>
Signed-off-by: gittrekt <[email protected]>
A few points to mention:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - maybe at least some docs update for deployment, would be nice
workflow_dispatch: | ||
push: | ||
tags: | ||
- 'v*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I created the workflow, I was a bit hesitant to use a required tag format, as it was not 100% established flow.. And I'm still a bit hesitant...although, I consider this as good practice. jfyi - We should
- describe the exact deployment flow in the docs
- Maybe introduce a bash/batch script
release.sh --minor
or something for consistent runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version tags work very well at this point. I think it should be good for this use case.
The runs should be consistent other than workflow_dispatch. I can take a second look and maybe see if we can use consistent naming in workflow_dispatch case to also use version tags. I have a few private repos that use them without problems, assuming the right release tags are used (v0.0.0 or v0.0.0-RC1).
I can throw comments in. I'm always bad at documentation 😆
153bd04
to
2021078
Compare
I had to rename my branch due to a conflict. Will have to open new PR. @ohager |
Updated action CI/CD