Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refresh token forces refresh #11

Merged
merged 1 commit into from
Apr 4, 2023
Merged

feat: refresh token forces refresh #11

merged 1 commit into from
Apr 4, 2023

Conversation

tofran
Copy link
Member

@tofran tofran commented Apr 4, 2023

instead of checking if token refresh is required (previous behaviour)

@tofran
feat: refresh token forces refresh
b6d9888 
instead of checking if token refresh is required (previous behaviour)
@tofran tofran requested a review from pdrbrnd April 4, 2023 15:54
@tofran tofran self-assigned this Apr 4, 2023
pdrbrnd
pdrbrnd approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@pdrbrnd pdrbrnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we should be returning the boolean, but I guess it might be handy to check if the refresh was successful

@tofran tofran merged commit 57febd0 into main Apr 4, 2023
@tofran tofran deleted the force-refresh-token branch April 4, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdrbrnd pdrbrnd pdrbrnd approved these changes

Assignees

@tofran tofran

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tofran @pdrbrnd