Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OTEL_SERVICE_NAME #64

Merged
merged 1 commit into from
May 13, 2021
Merged

Add support for OTEL_SERVICE_NAME #64

merged 1 commit into from
May 13, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented May 12, 2021

Description

Adds support for OTEL_SERVICE_NAME environment variable and updated otel dep to 1.2.0

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Tested manually
  • Added automated tests

Checklist:

  • Changelogs have been updated
  • Unit tests have been added/updated
  • Documentation has been updated

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #64 (fdda834) into main (8fcdd94) will increase coverage by 0.32%.
The diff coverage is 85.71%.

❗ Current head fdda834 differs from pull request most recent head 0e82de3. Consider uploading reports for the commit 0e82de3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   63.87%   64.19%   +0.32%     
==========================================
  Files           7        7              
  Lines         155      162       +7     
  Branches       22       21       -1     
==========================================
+ Hits           99      104       +5     
- Misses         49       50       +1     
- Partials        7        8       +1     
Impacted Files Coverage Δ
splunk_otel/tracing.py 53.57% <50.00%> (-0.82%) ⬇️
splunk_otel/options.py 80.59% <89.47%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcdd94...0e82de3. Read the comment docs.

@owais owais force-pushed the support-name branch 4 times, most recently from 2ad0827 to bff81da Compare May 12, 2021 23:01
@owais owais requested review from pellared and seemk and removed request for pellared May 12, 2021 23:01
@owais owais force-pushed the support-name branch 2 times, most recently from 97b778f to fdda834 Compare May 13, 2021 08:04
CHANGELOG.md Outdated
Comment on lines 14 to 15
- Deprecated support for `SPLUNK_SERVICE_NAME` environment variable.
Please use `OTEL_SERVICE_NAME=<my-service-name>` instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved to ### Deprecated section.
Reference: https://keepachangelog.com/en/1.1.0/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

Also upgraded Otel dependency to 1.2.0
@owais owais merged commit de32c46 into main May 13, 2021
@owais owais deleted the support-name branch May 13, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants