Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreUrls config in docload instrumentation #392

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Conversation

t2t2
Copy link
Contributor

@t2t2 t2t2 commented Jun 20, 2022

Description

Client reported a bug that ignoreUrls doesn't work. Looking into it found that they meant script tag on page pre-load event was being reported. So yeah the instrumentation was missing ignoreUrls config option

SWAT-4743

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Added integration tests

@t2t2 t2t2 requested review from a team as code owners June 20, 2022 17:02
@t2t2 t2t2 temporarily deployed to integration June 20, 2022 17:08 Inactive
@t2t2 t2t2 temporarily deployed to integration June 20, 2022 17:15 Inactive
@t2t2 t2t2 temporarily deployed to integration June 20, 2022 17:24 Inactive
@t2t2 t2t2 merged commit 5ac10d5 into main Jun 21, 2022
@t2t2 t2t2 deleted the ignore-urls-docload branch June 21, 2022 09:47
sfishel-splunk pushed a commit to sfishel-splunk/splunk-otel-js-web that referenced this pull request Jun 22, 2022
sfishel-splunk pushed a commit to sfishel-splunk/splunk-otel-js-web that referenced this pull request Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants